Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.6] UrlDispatcher - add_routes returns a list of AbstractRoutes (#4141) #4233

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

asvetlov
Copy link
Member

Co-Authored-By: Andrew Svetlov andrew.svetlov@gmail.com.
(cherry picked from commit 60e6c22)

Co-authored-by: Zlatan zlatan.sicanica@gmail.com

)

Co-Authored-By: Andrew Svetlov <andrew.svetlov@gmail.com>.
(cherry picked from commit 60e6c22)

Co-authored-by: Zlatan <zlatan.sicanica@gmail.com>
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 18, 2019
@codecov-io
Copy link

codecov-io commented Oct 18, 2019

Codecov Report

Merging #4233 into 3.6 will decrease coverage by 0.4%.
The diff coverage is 94.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.6    #4233      +/-   ##
==========================================
- Coverage   97.97%   97.56%   -0.41%     
==========================================
  Files          44       43       -1     
  Lines        8874     8841      -33     
  Branches     1390     1383       -7     
==========================================
- Hits         8694     8626      -68     
- Misses         71       92      +21     
- Partials      109      123      +14
Impacted Files Coverage Δ
aiohttp/streams.py 97.4% <ø> (-0.55%) ⬇️
aiohttp/web.py 99.04% <ø> (-0.48%) ⬇️
aiohttp/worker.py 96.63% <ø> (-0.91%) ⬇️
aiohttp/__init__.py 100% <100%> (ø) ⬆️
aiohttp/web_response.py 97.69% <100%> (-0.5%) ⬇️
aiohttp/cookiejar.py 100% <100%> (ø) ⬆️
aiohttp/web_urldispatcher.py 99.09% <100%> (-0.02%) ⬇️
aiohttp/helpers.py 96.58% <100%> (+0.06%) ⬆️
aiohttp/resolver.py 100% <100%> (ø) ⬆️
aiohttp/typedefs.py 92.59% <100%> (-7.41%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d8f62b...e95a2f0. Read the comment docs.

@asvetlov asvetlov merged commit 62ebaa2 into 3.6 Oct 18, 2019
@asvetlov asvetlov deleted the backport-60e6c22-3.6 branch October 18, 2019 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants